Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting dependencies and configuration #20

Conversation

cogniSyb
Copy link
Collaborator

Fix #18

Test URLs:
N/A

Changes

  • Update dependencies
  • Remove unneeded stylelint ignore comments

Configuration

  • Adding config to accept BEM classes, from Volvo Trucks.
  • I’ve set for media-feature-range-notation the notation style "prefix" instead of the standard "context". This means that we keep expecting @media (min-width: 768px) to be used instead of @media (width >= 768px) {}
  • For declaration-block-no-redundant-longhand-properties an exception is set for inset. When top: 0; right: 0; bottom: 0; left: 0; is used, then inset: 0; is expected. This is now disabled. Let’s discuss in the team whether we agree to remove the exception.

@cogniSyb cogniSyb linked an issue Aug 15, 2023 that may be closed by this pull request
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 15, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@cogniSyb cogniSyb closed this Aug 15, 2023
@cogniSyb cogniSyb deleted the 18-update-linting-dependencies-and-configure-linting-check-in-github branch August 15, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update linting dependencies and configure linting check in Github
1 participant